search

tenstorrent / tt-tvm

TVM for Tenstorrent ASICs
Apache License 2.0
18 stars 6 forks source link

Allow masked_fill to handle non-boolean/hot tensor masks #4

Closed JushBJJ closed 3 months ago

JushBJJ commented 5 months ago

Thanks @Lewis300 for the patch!

This patch is required to get Qwen1.5 0.5B bounty working: https://github.com/tenstorrent/tt-buda-demos/issues/20 Bounty PR: https://github.com/tenstorrent/tt-buda-demos/pull/37

Lewis breaks his explanation down here: https://github.com/tenstorrent/tt-buda-demos/issues/20#issuecomment-2053728300

nvukobratTT commented 3 months ago

@JushBJJ first of all sorry for waiting a bit for a review on this change. However, the change looks good and it's approved!

One last think is to rebase it to the latest main and resolve minor conflicts. Once you mange to do so, I'm going to merge this change into the main branch :))

Thanks for pushing this effort together with rest of the team!

JushBJJ commented 3 months ago

There you go :)