search

tenstorrent / tt-umd

User-Mode Driver for Tenstorrent hardware
Apache License 2.0
9 stars 5 forks source link

Remove global functions #105

Closed broskoTT closed 1 day ago

broskoTT commented 1 month ago

There are many functions which accept TTDevice/PCIDevice as a first argument -> These should be moved as private members of these classes. There are also some functions which should be private members of tt_SiliconDriver. There are also some functions which can go to a new file "system_utils.h" and be implemented as global there, so that its clear they aren't tied to any specific class.

Revisit all global functions.

broskoTT commented 1 day ago

Worked on this in several PRs such as #253 #149 #144 and #155, but most of what was captured by this issue has been fixed since