search

tenstorrent / tt-umd

User-Mode Driver for Tenstorrent hardware
Apache License 2.0
9 stars 5 forks source link

Remove dynamic tlb config from constructor #131

Closed pjanevskiTT closed 3 weeks ago

pjanevskiTT commented 1 month ago

Remove dynamic_tlb_config map from tt_SiliconDevice constructor.

Part of the larger effort #118. This is just removing one of the problems that we are facing with tt_SiliconDevice constructor.

broskoTT commented 4 weeks ago

Might be worth creating a Metal branch, updating its UMD submodule, fixing up whatever breaks (somewhere Metal must be constructing a tt_SiliconDevice) and then running Metal CI.

The ideal way would be making two-phase changes for each API change that we make. That means, implement the new api while keeping old functional. Then change tt-metal usage to new api. Then delete the old api here. That way we don't block other improvements in UMD from being merged into metal. However, this only solves problems if we have a high throughput of code changes in UMD, but since we don't, this might be fine.

All this said, please do create an experimental tt-metal branch and verify everything will remain functional after this change before merging this.

pjanevskiTT commented 3 weeks ago

Builds with tt-metal, merging...