search

tenstorrent / tt-umd

User-Mode Driver for Tenstorrent hardware
Apache License 2.0
9 stars 5 forks source link

Add pre-commit to CI #200

Closed blozano-tt closed 2 days ago

blozano-tt commented 2 weeks ago 
          Probably easiest with this: https://github.com/pre-commit/action

Then the GitHub action will do the same thing as what runs locally, but catches pushes from a client without pre-commit configured and those that pushed with --no-verify. It'll run slower since it'll check all files, I think. Maybe some extra configuration to compare against main and find a subset to run against. But if it's fast enough that extra legwork may not be warranted.

_Originally posted by @afuller-TT in https://github.com/tenstorrent/tt-umd/pull/192#discussion_r1810964098_

pjanevskiTT commented 2 days ago

@broskoTT status?

afuller-TT commented 2 days ago

If someone wants to do it on UMD, should be able to just copy/paste these lines from Metal: https://github.com/tenstorrent/tt-metal/blob/main/.github/workflows/all-static-checks.yaml#L11-L35 I've had that running for a little while now and seems good.

blozano-tt commented 2 days ago

Closed as completed in #203