search

tenstorrent / tt-umd

User-Mode Driver for Tenstorrent hardware
Apache License 2.0
9 stars 5 forks source link

Add pre-commit in CI #203

Closed blozano-tt closed 2 weeks ago

blozano-tt commented 2 weeks ago

It runs pre-commit checks on the files that have been changed (not the whole repo).

I setup the workflow to generate a PR targeting the PR branch, with the required fixes to satisfy the linters/formatters.

Developers can review that PR, and accept/reject/modify the proposed changes.

In this pre-commit PR, I added a dummy change to a CMake file, and the CMake formatter made a change.

The workflow generated this PR: https://github.com/tenstorrent/tt-umd/pull/205

What do you think?

This way we can add all of our linters/formatters/tidy-ers directly in the pre-commit-config.yaml

I was thinking it would be cool if it could comment or notify people about that PR, but that’s just icing.

broskoTT commented 2 weeks ago

Creating automatic PRs for this seems a bit overwhelming. It looks to me there would be an explosion of these PRs. Maybe just block existing PRs until the format issues are fixed? Not sure if that's all what this pre-commit which you added does.