tenstorrent / tt-umd

User-Mode Driver for Tenstorrent hardware
Apache License 2.0
9 stars 5 forks source link

Hardware/Firmware constant #include file cleanup #244

Open joelsmithTT opened 6 days ago

joelsmithTT commented 6 days ago

UMD contains architecture-specific header files that live under src/firmware/riscv; these headers define hardware and firmware constants. UMD's use of these constants follow a pattern: the application or unit test fills out structs (e.g. tt_device_l1_address_params, tt_driver_eth_interface_params, etc.) and passes them into the tt_SiliconDevice.

There are some problems with how this is implemented:

To better understand how best improve this situation, it would be useful to know the following. Out of the parameters UMD gets from eth_interface.h, eth_l1_address_map.h, host_mem_address_map.h, l1_address_map.h, and noc_parameters.h, which are:

joelsmithTT commented 6 days ago

Some analysis is captured at https://docs.google.com/document/d/1UBjhn9C-ivxPAFu-7u0fTunNDFRltTiZIRd8XgAsYgo/edit?tab=t.0