Fix broken unit tests + update CMake infra

tenstorrent / tt-umd

User-Mode Driver for Tenstorrent hardware

Apache License 2.0

9 stars 5 forks source link

Fix broken unit tests + update CMake infra #31

Closed vtangTT closed 2 months ago

vtangTT commented 2 months ago

Included in PR:

CMake infra for tt-metal to include umd with add_subdirectory
CMake infra for tests
CPM for yaml-cpp and boost::interprocess
Fix/re-enable GS/WH/BH unit tests

For BBE:

I'm ensuring the make flow is not broken (running make build and make test)

vtangTT commented 2 months ago

Overall looks reasonable. Some suggestions

Augment readme with build instructions for CMake (command-line recipe for impatient people to copy/paste)

Deprecate the Makefile build flow (it still needs to support BBE, up to you whether it correctly generates the unit tests)

What do you mean by deprecate the makefile build flow? Remove it from the readme and replace it with cmake as the main build system?

joelsmithTT commented 2 months ago

What do you mean by deprecate the makefile build flow? Remove it from the readme and replace it with cmake as the main build system?

Pretty much. It still has to be there for BBE, but you could remove it from the readme in favor of CMake instructions (or remark in the readme that it is deprecated / no longer maintained).