search

tenstorrent / tt-umd

User-Mode Driver for Tenstorrent hardware
Apache License 2.0
9 stars 5 forks source link

hid simulation device thus flat buffers from public headers #34

Closed marty1885 closed 2 months ago

marty1885 commented 2 months ago

See https://github.com/tenstorrent/tt-metal/issues/11640 for details.

This PR hides flatbuffers from public UMD headers so 3rd party projects can compile successfully without matching the exact version of flatbuffers used by UMD/TTNN. This is impossible for some projects (ex: GGML)

If ok, this PR can be merged and pulled into tt-metal AFTER https://github.com/tenstorrent/tt-metal/pull/11641 is merged

vtangTT commented 2 months ago

Yep makes sense to me, thank you!

vtangTT commented 2 months ago

closing, this change merged by https://github.com/tenstorrent/tt-umd/pull/36