API cleanup and refinement

tenstorrent / tt-umd

User-Mode Driver for Tenstorrent hardware

Apache License 2.0

9 stars 5 forks source link

API cleanup and refinement #50

Closed broskoTT closed 2 days ago

broskoTT commented 1 month ago

Copied from https://docs.google.com/document/d/1DoDwJgGzvXiifB2jL0VRb2WmSvtPPcStqq7cgbSU04c/edit

Identify and remove unnecessary APIs in tt_device, tt_SiliconDevice classes
Simplify and standardize remaining interfaces
Opportunity for more consistency in argument order among IO-related methods
Document API changes
Maintain tt_device interface, for now – it’s what Metal expects

Also, #41 probably addresses a part of this. See what needs to be done afterwards.

pjanevskiTT commented 1 month ago

Since I am going through the API for #48 , I will assign this to myself as well. However, I will wait for @vtangTT to merge #41 and then see what is left

broskoTT commented 1 month ago

Vincent will now merge the PR, but I think there is now a larger effort to see where we're heading with the API #57 . The actual changes won't be part of Phase0 though. Also, you will add some documentation through #48

Maybe split this issue up in smaller ones that still make sense (from your bulleted list).

pjanevskiTT commented 2 days ago

This issue already has smaller issues in terms of redesign, or @broskoTT will open those, so closing this