tenstorrent / tt-umd

User-Mode Driver for Tenstorrent hardware
Apache License 2.0
9 stars 5 forks source link

Separate host arch specific code to directories #75

Closed pjanevskiTT closed 1 month ago

pjanevskiTT commented 1 month ago

Fixes #56

driver_atomics files separated into specific directories for each possible host arch that we want to support for now

TODO

joelsmithTT commented 1 month ago

The conditional compilation for x86 vs arm vs riscv is fine as it's not something that the build system or user needs to worry about. I am not convinced that the additional complexity this introduces (multiple files, additional build logic) is worth the benefit.

pjanevskiTT commented 1 month ago

This requires some changes in the build system of Metal, which is not a priority at the moment, I will move the PR to draft just to not forget and we can change what is needed later on

The conditional compilation for x86 vs arm vs riscv is fine as it's not something that the build system or user needs to worry about. I am not convinced that the additional complexity this introduces (multiple files, additional build logic) is worth the benefit.

OK, makes sense. If it somehow starts to blow up, we can come back and reconsider