tentone / geo-three

Tile based geographic world map visualization library for threejs

https://tentone.github.io/geo-three/docs/

MIT License

700 stars 112 forks source link

Closed christjt closed 3 years ago

christjt commented 3 years ago

18 did not actually fix emitting declaration types

There seems to be an issue with rollup, (see https://github.com/rollup/plugins/issues/394)

This PR adds the workaround found at the bottom of the issue tracked in rollup and bundling with rollup will now properly emit types.

christjt commented 3 years ago

@tentone Can you approve running workflows?

tentone commented 3 years ago

Hello

Sorry for the delay. I have approved to run the workflows.

Changes seem to be okay and test ran without any problem.

Merged!

Thanks a lot!

christjt commented 3 years ago

No problem, thanks for approving. When can I expect this to be released to npm?