Implement second pipe function to 'download' from nextcloud

tentwentyfour / nextcloud-link

Javascript/Typescript client that communicates with Nextcloud's WebDAV and OCS APIs

MIT License

56 stars 7 forks source link

Implement second pipe function to 'download' from nextcloud #10

Closed ghost closed 4 years ago

ghost commented 4 years ago

added function to pipe data located at the provided path into the provided writable stream
renamed pipeStream to uploadFromStream and downloadToStream
[x] I have carefully evaluated the risks of this change
[x] This change does not remove existing functionality
[x] I have written tests to cover all risks
[x] I updated the docs

floriansimon1 commented 4 years ago

Do you think just removing the function would be better? Sure, that requires amajor version bump but it might be worth it given the small adoption the library has

kwisatz commented 4 years ago

Do you think just removing the function would be better? Sure, that requires amajor version bump but it might be worth it given the small adoption the library has

I simply didn't think that this should make it a nextcloud-link v2.0.0… from a semver POV, yes, it could also be done like that, but feels odd.

ghost commented 4 years ago

I could add a deadline when I'll remove the function alltogether

floriansimon1 commented 4 years ago

I could add a deadline when I'll remove the function alltogether

Yeah, you could say something along the line of "this will be removed in version 2"

ghost commented 4 years ago

Yess, update incoming