tentwentyfour / nextcloud-link

Javascript/Typescript client that communicates with Nextcloud's WebDAV and OCS APIs
MIT License
57 stars 7 forks source link

Add github actions for CI ? #11

Closed kwisatz closed 4 years ago

kwisatz commented 4 years ago

We could run CI on github using actions, but not with the current set-up that uses docker-compose. At least I don't think there are actions to support that. Instead, all Nextcloud functionality should probably be mocked anyway.

name: Node.js CI

on:
  pull_request:
    branches:
    - master
  push:
    branches:
    - master
    - release/*

jobs:
  build:

    runs-on: ubuntu-latest

    strategy:
      matrix:
        node-version: [8.x, 10.x, 12.x]

    steps:
    - uses: actions/checkout@v2
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v1
      with:
        node-version: ${{ matrix.node-version }}
    - run: npm install
    - run: npm run build --if-present
    - run: npm test
      env:
        CI: true
ghost commented 4 years ago

it is possible though https://github.com/peter-evans/docker-compose-actions-workflow

kwisatz commented 4 years ago

oh, neat!

Then we can go in two steps. First have some CI at all, then later drop the actual Nextcloud instance, or just use it for some tests.

floriansimon1 commented 4 years ago

I would argue against removing the nextcloud instance because it's happened to me quite a few times that code that worked with the open webdav server didn't work when used with actual Nextcloud containers.

Furthermore, it also helps us get an idea about the speed of our implementation, which, last time I tried, was a bit slow