Compiling with typescript does not work

tentwentyfour / nextcloud-link

Javascript/Typescript client that communicates with Nextcloud's WebDAV and OCS APIs

MIT License

56 stars 7 forks source link

Compiling with typescript does not work #3

Closed jonaskello closed 5 years ago

jonaskello commented 5 years ago

I try to use this package but when I compile with tsc I get this error:

$ tsc -b packages && yarn promaster-markdown-build-esm
node_modules/nextcloud-link/compiled/source/types.d.ts:4:38 - error TS7019: Rest parameter 'parameters' implicitly has an 'any[]' type.

This is using latest version 1.0.16. Is there a fix for this?

floriansimon1 commented 5 years ago

I think this might be due to your tsconfig. Do you maybe use the noImplicitAny feature of Typescript?

If so, it's just that we never tested the library with it. I'll see what I can do to remedy this.

floriansimon1 commented 5 years ago

I believe v1.0.17 should address the issue. Let me know if it doesn't.

We apologize for the inconvenience.

jonaskello commented 5 years ago

Yes, confirmed it compiles with v1.0.17 :-). Thanks for the quick fix 👍 🚀