search

tentwentyfour / nextcloud-link

Javascript/Typescript client that communicates with Nextcloud's WebDAV and OCS APIs
MIT License
57 stars 7 forks source link

feat: Add common method getFileOrFolderCreator #6

Closed rvsteen closed 5 years ago

rvsteen commented 5 years ago

feat: Add common method getObjectCreator chore: make imports more consistent docs: update README for OCS docs: add new common methods feat: compile "types" to types.js fix: add longer timeout for createFolderHierarchy test

Common methods are that serve specific purposes and will not return the data from Nextcloud directly.

floriansimon1 commented 5 years ago

Most of my comments are bikeshedding. The real thing that puzzles me ks that we're building types.js, but if the justification is valid, I guess that's also fine

floriansimon1 commented 5 years ago

Since there's no new release here, we can merge this easily. However, before creating a new release, we need to make sure that the types are properly exposed

floriansimon1 commented 5 years ago

Forgot to say - thanks for your time & effort!

rvsteen commented 5 years ago

Thanks for all the feedback :)