tenzir / threatbus

🚌 Threat Bus – A threat intelligence dissemination layer for open-source security tools.
https://docs.tenzir.com/threatbus
BSD 3-Clause "New" or "Revised" License
258 stars 16 forks source link

Correctly validate 'apps.misp.api.*' config settings #161

Closed lava closed 3 years ago

lava commented 3 years ago

:notebook_with_decorative_cover: Description

The 'apps.misp.api' key is optional, but the code used to assume that if it is present, then all three of the subkeys 'api.host', 'api.ssl' and 'api.key' are also present.

We now validate that this is indeed the case.

:memo: Checklist

:dart: Review Instructions

Try providing an invalid MISP config and verify that threatbus doesn't start and doesn't crash with an unhandled exception.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 53b78670f2da3c4a185d91cd90109af9e0ba03b8 into aa34f5332ae24d4848cecc778454863fc8fd31f3 - view on LGTM.com

new alerts: