search

teocomi / BCFier

Extensible BCF client and tools
http://bcfier.com/
GNU General Public License v3.0
121 stars 73 forks source link

Installer for XbimXplorer #41

Open teocomi opened 7 years ago

teocomi commented 7 years ago

Hey @CBenghi , I'm about to roll out a new version of BCFier with some improvements. Should I include support for XbimXplorer in the installer? If so how? I'm not familiar with it...

CBenghi commented 7 years ago

Hello, sorry for the late reply I was on holiday. No need to do anything in the installer; plugins have an online update system, I'll have to merge your code changes and push the library to our online repo.

Thanks for letting me know. I'll keep you posted.

Claudio

CBenghi commented 7 years ago

I've merged your latest changes to my repository. I'll make the plugin available to Xplorer soon.

I wonder if it would instead help to distribute your core libs as a nuget package; updates to third parties might be simpler, but maybe it's overkill.

Thanks, Claudio

teocomi commented 7 years ago

Hi Claudio, it's a good idea but yes, it might be overkill for now given that as far as I know only Xplorer is using BCFier.

CBenghi commented 7 years ago

On the other hand, once the package is in nuget more people might use it, and it's very little effort to add a nuspec file to the project. I can give it an initial look if you wish and send a PR if it works. You'll have to create a nuget user, though, I think it would be better for IP if it was done in your name.

teocomi commented 7 years ago

Sounds good, we've got nothing to lose. Appreciate that.

CBenghi commented 7 years ago

Hello, I've started looking into the nuget packaging this morning and one thing seems odd in the architecture. All other projects are marked 'InternalsVisibleTo' from BCFier.

I think this should be changed (something made available as public) to make the API usable to others.

XbimXplorer uses the following:

'AddView' does not contain a definition for 'Issue' 'AddView' does not contain a definition for 'TempFolder' 'AddView' does not contain a definition for 'TextBlockInfo' 'AddView' does not contain a definition for 'AddViewpoint'

but I can't compile the others, would it be OK to change the signatures of these 4 (or add appropriate methods)?

Let me know and I'll progress. Claudio

teocomi commented 7 years ago

Hi Claudio, yes I guess that decision was made when BCFier wasn't Open Source yet, feel free to change the signature.

CBenghi commented 7 years ago

Got it, thanks.