search

teodesian / Selenium-Remote-Driver

Perl Bindings to the Selenium Webdriver server
174 stars 90 forks source link

Fix the action type for button_up() #459

Closed bschmalhofer closed 1 year ago

bschmalhofer commented 3 years ago

I have been looking at DragAndDrop failures of the Selenium tests for OTOBO. There I noticed that pointerDown was emitted twice. I think that the WebDriver action should be pointerUp instead of pointerDown for the subbutton_up().

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.05%) to 62.052% when pulling 177a44dc1503b95f5325e5d5f8e38f5098f5595e on bschmalhofer:bschmalhofer-patch-1 into c0f15edc41f7178f8fc531c3a02cf47c6faa3f39 on teodesian:master.

bschmalhofer commented 1 year ago

I still think the the method button_up() should be fixed. I updated the PR, making sure it still applies to the current HEAD of master.

teodesian commented 1 year ago

Should be in 1.49, just uploaded to CPAN

bschmalhofer commented 1 year ago

Thanks a bunch. I updated my required version of Selenium::Remote::Driver and closed https://github.com/RotherOSS/otobo/issues/727 .