Closed msaps closed 4 years ago
Any plan to merge this PR?
Any plan to merge this PR? It is really helpful !!.
Hey, sorry for the late response, I have been really busy lately. First of all thank you for the PR, secondly, why not make the meta structure public and allow for injecting it from the outside into the JukeboxItem?
I see your builder is a clone of the Meta structure, why not change the existing meta structure?
@teodorpatras no worries 👍
I've just gone back and updated the PR with your suggestions:
JukeboxItem.MetaBuilder
now inherits from JukeboxItem.Meta
and overrides the various properties that should be configurable. customMetaBuilder
still works the same, allowing for a combination of the MPMediaItem
metadata and any custom specified meta to be utilised. JukeboxItem.Meta
and JukeboxItem.MetaBuilder
are now in a JukeboxItem
extension in JukeboxItemMeta.swift
.Cheers 😄
How can I get msaps new feature?
Has anyone been able to use custom meta data for lock screen and control center.
@msaps is the project still maintained? Why has this being closed? Thanks
@demetrio812 I was just cleaning up my open PR's - this has been open for about 3 years so I assumed it wasn't being maintained any further.. 😞
Adds
JukeboxItemMetaBuilder
to allow for custom metadata to be specified for aJukeboxItem
. A new publiccustomMetaBuilder
property is available on JukeboxItem; simply provide this with a builder with your custom data.Custom metadata takes precedence over any collected from
AVMetadataItem
, however a combination of the two is still evaluated and used where appropriate.Resolves #41.