Feature: Add ability to set custom metadata on JukeboxItem.

teodorpatras / Jukebox

Player for streaming local and remote audio files. Written in Swift.

MIT License

551 stars 122 forks source link

Feature: Add ability to set custom metadata on JukeboxItem. #56

Closed msaps closed 5 years ago

msaps commented 7 years ago

Adds JukeboxItemMetaBuilder to allow for custom metadata to be specified for a JukeboxItem. A new public customMetaBuilder property is available on JukeboxItem; simply provide this with a builder with your custom data.

Custom metadata takes precedence over any collected from AVMetadataItem, however a combination of the two is still evaluated and used where appropriate.

Resolves #41.

wenbinf commented 7 years ago

Any plan to merge this PR?

almatri commented 7 years ago

Any plan to merge this PR? It is really helpful !!.

teodorpatras commented 7 years ago

Hey, sorry for the late response, I have been really busy lately. First of all thank you for the PR, secondly, why not make the meta structure public and allow for injecting it from the outside into the JukeboxItem?

I see your builder is a clone of the Meta structure, why not change the existing meta structure?

msaps commented 7 years ago

@teodorpatras no worries 👍

I've just gone back and updated the PR with your suggestions:

JukeboxItem.MetaBuilder now inherits from JukeboxItem.Meta and overrides the various properties that should be configurable.
customMetaBuilder still works the same, allowing for a combination of the MPMediaItem metadata and any custom specified meta to be utilised.
JukeboxItem.Meta and JukeboxItem.MetaBuilder are now in a JukeboxItem extension in JukeboxItemMeta.swift.

Cheers 😄

madlyn commented 7 years ago

How can I get msaps new feature?

ghost commented 7 years ago

Has anyone been able to use custom meta data for lock screen and control center.

demetrio812 commented 5 years ago

@msaps is the project still maintained? Why has this being closed? Thanks

msaps commented 5 years ago

@demetrio812 I was just cleaning up my open PR's - this has been open for about 3 years so I assumed it wasn't being maintained any further.. 😞