teodorpatras / Jukebox

Player for streaming local and remote audio files. Written in Swift.
MIT License
551 stars 122 forks source link

Xcode 9 and swift 4 compatibilty #96

Open tenzinsamten opened 6 years ago

tenzinsamten commented 6 years ago

The build fails for Jukebox for swift 4. imported the library using pod

pod 'Jukebox'

BogdanPintilei commented 6 years ago

@tenzinsamten if you change the Swift Language Version to Swift 3.3 in build settings for the Jukebox pod target, it works

alokvnair commented 6 years ago

@tenzinsamten write this command to end of your Podfile to solve this issue while installing pod or as @BogdanPintilei mentioned, change Swift Language Version to 3.3 everytime you do pod install.

post_install do |installer|
    installer.pods_project.targets.each do |target|
        if target.name == 'Jukebox'
            target.build_configurations.each do |config|
                config.build_settings['SWIFT_VERSION'] = '3.3'
            end
        end
    end
end
sam961 commented 5 years ago

I had updated the pod for swift 4.2 pod 'Jukebox', :git => 'https://github.com/sam961/Jukebox.git',:branch => 'swift-4.2'

terrysulivan commented 5 years ago

Hi @sam961! This branch 'https://github.com/sam961/Jukebox.git',:branch => 'swift-4.2' doesn't seem to exist anymore?