search

teodorpatras / SideMenuController

A side menu controller written in Swift for iOS
MIT License
1.16k stars 289 forks source link

iPhone X status bar wrong height #119

Open RuslanasMobOn opened 7 years ago

RuslanasMobOn commented 7 years ago

iPhone X have 44 points height status bar, so instead of line let DefaultStatusBarHeight : CGFloat = 20 should be let DefaultStatusBarHeight : CGFloat = UIApplication.shared.statusBarFrame.size.height in UIKitExtensions.swift file

davidseek commented 7 years ago

I was here because of that issue, but your comment fixed it for me. Thank you :)

I have just replaced the constant DefaultStatusBarHeight with UIApplication.shared.statusBarFrame.size.height

sonjh1217 commented 7 years ago

But in my application UIApplication.shared.statusBarFrame.size.height is 20pts even on iPhone X. Do you know this issue?

samuelsainz commented 7 years ago

@sonjh1217 I have the same issue. Did you find a solution? Thanks

sonjh1217 commented 6 years ago

https://stackoverflow.com/questions/46703835/on-iphone-x-uiapplication-sharedapplication-statusbarframe-size-height-is-20/46829679#46829679 https://stackoverflow.com/questions/46703835/on-iphone-x-uiapplication-sharedapplication-statusbarframe-size-height-is-20/46829679#46829679 Could you try the answer? I also think it was because the launch screen doesn’t fit iPhone X.

On 20 Oct 2017, at 01:33, Samuel Sainz notifications@github.com wrote:

@sonjh1217 https://github.com/sonjh1217 I have the same issue. Did you find a solution? Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/teodorpatras/SideMenuController/issues/119#issuecomment-337964417, or mute the thread https://github.com/notifications/unsubscribe-auth/AG6nWk0IzVZmP0VvalZzZ3x1CfopPVhKks5st3nTgaJpZM4PVv0Y.

rajan2211 commented 5 years ago

This is not included in 0.2.4. How to get this update?

cjlarsen commented 5 years ago

This should probably be closed