teoh4770 / pomotama

A Pomofocus clone with React and TypeScript. For personal usage + learning purposes (not in production!).
https://pomotama.netlify.app/
MIT License
10 stars 3 forks source link

[Bug] Any changes in the setting component will immediately update the state #1

Closed teoh4770 closed 6 months ago

teoh4770 commented 6 months ago

Any changes in the setting component will immediately update the state. -> For example, update the pomodoro timer setting will update the pomodoro timer state.

Potential issue with this problem? -> While timer is running, setting the timer setting value will mess up with the current timer value

Previous flow:
update the timer setting in the setting section -> update the timer state immediately

The flow should be like:
update the timer setting in the setting section -> user click confirm (either with enter key or the button) -> update the timer state after form is submitted
teoh4770 commented 6 months ago

link about dialog: https://blog.webdevsimplified.com/2023-04/html-dialog/

teoh4770 commented 6 months ago