Open teojunda opened 4 months ago
No. We choose contact name as a unique identifier as to prevent the social worker from mistakenly adding the same client multiple times.
A very simple work-around would be to add something else to the contact names to differentiate them.
For example, two Dylan Lims could be Dylan Lim NUS and Dylan Lim NTU.
Team chose [response.Rejected
]
Reason for disagreement: > No. We choose contact name as a unique identifier as to prevent the social worker from mistakenly adding the same client multiple times.
Firstly, using name as a person's unique identified is not a suitable choice, since name is not unique to every person. Instead, it is more suitable to use alternatives like ID numbers.
Secondly, there is a possibility of 2 clients having the same name. Therefore, instead of outrightly preventing this, it would be better to give a warning so that the user can make the final decision.
A very simple work-around would be to add something else to the contact names to differentiate them.
This work-around may work. However, it still causes inconvenience to the user as he cannot use the application in the way that he intends to. It is not ideal to expect users to have to find work-arounds regarding feature flaws with the application, because it might make the app more troublesome than the value it provides.
Steps to reproduce:
First, user executes![Screenshot 2024-04-19 at 4.33.17 PM.png](https://raw.githubusercontent.com/teojunda/pe/main/files/5ee61145-44e1-41cc-9ada-ad706addcf7c.png)
add --name=Theodore Koo --phone=98001715 --email=theodore@example.com --addr=Prince Street, Block 144, #19-14 --tags=Disabled --note=Lactose Intolerant
User executes![Screenshot 2024-04-19 at 4.33.55 PM.png](https://raw.githubusercontent.com/teojunda/pe/main/files/d3ba6dd7-28b8-41f8-a06f-0fc75591b198.png)
add --name=Theodore Koo --phone=88001715 --email=theodorekhoo@example.com --addr=Prince Street, Block 145, #19-14 --tags=fit --note=hello
The user guide by mentions that user should "differentiate them by giving them different names". However, this will inconvenience the user. Therefore, Application should allow clients with the same name, especially when other fields like phone, email and address are different, since there are multiple people that can share the same name.