search

teokem / project-work-2018-CamilleAny

project-work-2018-CamilleAny created by GitHub Classroom
0 stars 1 forks source link

Project review by Majda Misini Ignjatovic #2

Open majdateokem opened 5 years ago

majdateokem commented 5 years ago

Hi Camille,

Please find my review of your project based on requirements on the course page.

First, thank you for the detailed introduction to your Master Thesis project. It made it easier to understand your research.

I my opinion this notebook meets the project requirements.

  1. I had no problems running the notebook on my computer. The instructions on how to run it are clear and the environment file works fine. The notebook is very well documented, with lots of equations and reference links, nice figures, and tables.

  2. The code used to read, write and manipulate data, works perfectly and is well documented.

  3. The notebook contains nice looking plots, each with a title and properly labeled axes.

  4. Figures have the right size and resolution. I just have a question about figure _TBN_productionplot.png. The width was set to 183 mm, is it supposed to be a double column figure?

  5. The notebook is archived in a repository with a digital object (DOI).

Overall, this is a really good project. It is well written, organised, and easy to follow and reproduce. I like the pictures in the introduction part. Great work on documenting the notebook.

Good luck with your PhD projects! Best, Majda

CamilleAny commented 5 years ago

Thank you for the review !

For the figure _TBN_productionplot.png, I just thought that putting it as a double column figure will ease its readability.

Best, Camille