teoks0199 / pe

0 stars 0 forks source link

Cannot add students with same name but different particulars. #3

Open teoks0199 opened 11 months ago

teoks0199 commented 11 months ago

image.png

When I try: add n/test p/123 e/test1@u.nus.edu th/test1 add n/test p/1234 e/test2@u.nus.edu th/test2 I am not allowed to add the second student.

However, it is possible for students to have the same name in the real world, but it is clear that they are different students as they have different phone numbers and emails and handles. Thus the duplicate checking for students should take their particulars into account too.

soc-pe-bot commented 11 months ago

Team's Response

Thank you for the feedback. However, as most students "in the real world" do not have the exact same full name as each other, users could simply indicate their surnames. Even in the unlikely event that 2 students have the exact same first name and surname, users could indicate their Chinese name or just use other identifiers to differentiate between them.

For example, "in the real world", Avengers who have to teach 2 students with the exact same name would use other identifiers to differentiate between them. Likewise, users could utilize this to differentiate between students of the exact same full name.

Warmest Regards,

Team F.A.K.E.J.A.R.V.I.S.

logofj (2).png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Yes, it is unlikely for 2 students to have the same name, but it is still possible and there are cases that do exist. And in such cases, this current implementation would pose an inconvenience, as such I agree that the severity can be low, but it should still be a bug that duplicate checking for students only takes the name into consideration and ignores other particulars. After all, it should be obvious that 2 students with different particulars are not the same.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]