search

teoljungberg / fx

Versioned database functions and triggers for Rails
MIT License
763 stars 77 forks source link

Find definitions in engines #18

Closed bibendi closed 5 years ago

bibendi commented 5 years ago

Hey!

It would be handy for us to have the ability to find SQL definitions in Rails engines. I've made some very safe fixes. Please, tell me if I should do something else or there is enough.

bibendi commented 5 years ago

@teoljungberg Hey! Sorry for the late response, I was swamped ( Can you take a look for the update? Thanks!

bibendi commented 5 years ago

@teoljungberg Hi again! I'm sorry to bother you but would you be able to review this PR when you have a chance?

teoljungberg commented 5 years ago

@bibendi Sorry for my slow responses, I'm away on vacation currently but I'm leaving this to look into it once I'm back. I hope that's fine with you for the time being!

teoljungberg commented 5 years ago

Hi @bibendi! There's one outstanding PR, but besides that - this looks good. Waiting for that to get resolved before we merge.

bibendi commented 5 years ago

Hey @teoljungberg! Thanks for your review! I think I've just resolved all your comments.

teoljungberg commented 5 years ago

Thanks for your contribution @bibendi!

I'll cut a release of this in a few days, please try the gem out from master in the meantime and let me know if you run into any issues.

bibendi commented 5 years ago

Hey @teoljungberg ! Could you roll out the release, please? We have many engines depend on this gem, and we experience a little bit discomfort when a gem connected from git. Thanks!

teoljungberg commented 5 years ago

@bibendi I released 0.4.0 just now. Let me know how the release works for you and your team.