teoljungberg / fx

Versioned database functions and triggers for Rails
MIT License
763 stars 77 forks source link

Tests fail on Postgres 11 and Up #89

Closed petergoldstein closed 2 years ago

petergoldstein commented 2 years ago

The specs fail when run on a more recent version of Postgres than 10.x, which EOLs this year. There are currently four more recent major versions - 11 - 14.

The failure is due to a change in syntax for trigger creation. In Postgres 10.x, the text EXECUTE PROCEDURE was included, as can be seen here - https://www.postgresql.org/docs/10/plpgsql-trigger.html

In later Postgres versions, this text was changed to EXECUTE FUNCTION as can be seen:

This mismatch causes specs to fail.

Is there any objection to updating the Postgres version in .travis.yml to 14? Making this change doesn't appear to impact the behavior of the gem, only whether the specs pass.

teoljungberg commented 2 years ago

Closed by https://github.com/teoljungberg/fx/commit/94b49971e6def226dfbdc6092cf9a3b1d990665e