teolvs / lca_graphic

BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Compare plot integration #1

Open ViCt0r99 opened 1 year ago

ViCt0r99 commented 1 year ago

Hi @teolvs,

I'm using your code to build a visualization library for Brightway. I may have some issues with understanding parts of your code and I want to keep the conversation with you until I'm confident that your code is properly integrated in our library if you'll have the time for that. First few things related to your prepared library:

teolvs commented 1 year ago

Hello @ViCt0r99,

I am glad to see this work has been used to build a a visualization library for Brightway. I would be happy to deal with you to help you integrating in your library to explain features or parts of the code. I took a look on the changes in your repository. It seems that you have mainly reorganised the code architecture to clean up the calls between each method. It was a bit messy indeed. In fact, I started to build the library exclusively on US EEIO database, and I adapted it for EcoInvent in a second step. Thus, you can found meaningful examples if you go back in the old commits in the notebook (~13 january). I compared "Metal windows, doors, and architectural products; at manufacturer" and "Wooden windows, door, and flooring; at manufacturer". Quite interesting example since you have actually impact transfer if you look at several impact categories such as : ('Impact Potential', 'GCC'), ('Impact Potential', 'HTOX'), ('Resource Use', 'LAND'), ('Resource Use', 'WATR')

Hopefully this answered your question.