teotigraphix / Framework4Bitwig

Bitwig controller API framework extensions.
GNU Lesser General Public License v3.0
59 stars 13 forks source link

Track Bank page is not adjusted when track is selected in Mix view #251

Closed git-moss closed 1 year ago

git-moss commented 4 years ago

If a track is selected in Mix layout and the track is outside of the current page, the page is not adjusted to display the track on the controller. It works fine when you select a track in the Arranger layout. It happens only with hierarchical banks created with CursorTrack.createSiblingsTrackBank()

Reproduce: 1) Test with Push 1 or 2 (or the simulator) 2) Create more than 8 tracks 3) Switch to Mix layout 4) Click on a track outside of the currently displayed track bank page on Push

Note: The page is also adjusted if you display clips and click on a clip on the track.

abique commented 4 years ago

How did you create the track cursor?

k0k0c commented 4 years ago

This issue is reproducible with TrackBank created with createSiblingsTrackBank as well as createTrackBank. CursorTrack is created with shouldFollowSelection = True and followCursorTrack is initialized to TrackBank. This reproduced only if the first track selected is on a page number that differs from the page number on which the next track is selected by more than one. I illustated this on two screenshot.

In this screenshot the Inst 26 track is selected and the track bank corresponds to the selected track. https://snipboard.io/eJSpnd.jpg

Next, I select the Inst 6 track in UI Bitwig. The TrackBank switches to the wrong page. https://snipboard.io/ielS2E.jpg

Reproduced in Arranger view and Clip view as well.

git-moss commented 3 years ago

Just wasted 2 hours reproducing a bug report by a user until I noticed that this bug already is known...

However, while testing I noticed another issue with the auto-follow of the siblings bank: If you click inside of a group and the clicked track is e.g. on the 2nd page, only the first page is selected. In the attached screenshots: 1) The first track is selected 2) The last track in the group is clicked (which is on the 2nd page) -> The first track of the first track is selected. 3) Clicking the previous track in the group fixes it again.

Can be tested with the Push 2 simulator.

TrackFollowInGroup1 TrackFollowInGroup2 TrackFollowInGroup3 .

git-moss commented 3 years ago

271 is related as well.

git-moss commented 2 years ago

Still in 4.3 Beta 4.

git-moss commented 1 year ago

Works fine now in 5.0.7!