feat: added `onRegionChangeComplete`. Improved others

teovillanueva / react-native-web-maps

Cross platform maps for react & react-native 🗺

https://teovillanueva.github.io/react-native-web-maps/

MIT License

57 stars 14 forks source link

feat: added `onRegionChangeComplete`. Improved others #1

Closed artalat closed 2 years ago

artalat commented 2 years ago

Added support for details property on the onRegionChange event listener.
Added support for onRegionChangeComplete event listener.
animateToRegion method now respects delta values, and zooms accordingly.

teovillanueva commented 2 years ago

Hey! Thanks for opening the first PR on the lib. I've reviewed what you added and it looks good 😊 Is there any chance you can update the docs on the nee event listener you've added? Thanks and welcome 😏

artalat commented 2 years ago

Sure, check now

artalat commented 2 years ago

Any update on this?

teovillanueva commented 2 years ago

Hey! I took the weekend to rest a little bit 😄 Just pushed a change to main, would you mind resolving the conflicts in yarn.lock and pushing? I've reviewed the code and looks good. Once you resolve that I'll create a new release 💪

artalat commented 2 years ago

Done

teovillanueva commented 2 years ago

Just release version 0.6.0, thanks for contributing :)

teovillanueva commented 2 years ago

@all-contributors please add @artalat for code

allcontributors[bot] commented 2 years ago

@teovillanueva

I've put up a pull request to add @artalat! :tada: