teovillanueva / react-native-web-maps

Cross platform maps for react & react-native 🗺
https://teovillanueva.github.io/react-native-web-maps/
MIT License
61 stars 15 forks source link

feat: Add support for Callout component #16

Closed YoussefHenna closed 1 year ago

YoussefHenna commented 1 year ago

Hey. Great work on this package! It's really amazing and long overdue.

I'm part of the Draftbit team and this will be a great addition to our component selection. The one thing we needed that was missing was the Callout component. This PR adds that component + some changes to Marker to accommodate the Callout

Screenshots

Default/Simple Callout

On default marker On custom marker
Screenshot_2 Screenshot_1

With tooltip enabled

On default marker On custom marker
Screenshot_4 Screenshot_3

With custom calloutAnchor

On default marker On custom marker
Screenshot_6* Screenshot_5
*callout is covering the marker

Summary of changes

YoussefHenna commented 1 year ago

@teovillanueva You get the chance to review this yet?

teovillanueva commented 1 year ago

Hey! I missed this, I'll try to review it today. :)

teovillanueva commented 1 year ago

It looks good to me! Im glad to hear that you are using the lib for such an amazing project. Would you be interested in setting up some tests for the project? I'll open an issue to keep track of it.

YoussefHenna commented 1 year ago

It looks good to me! Im glad to hear that you are using the lib for such an amazing project. Would you be interested in setting up some tests for the project? I'll open an issue to keep track of it.

Maybe at some point. Not in the next coming weeks though. Point me to the issue and I'll try to get to it in the near future.

teovillanueva commented 1 year ago

@all-contributors please add @YoussefHenna for doc and code

allcontributors[bot] commented 1 year ago

@teovillanueva

I've put up a pull request to add @YoussefHenna! :tada: