Closed YoussefHenna closed 1 year ago
@teovillanueva You get the chance to review this yet?
Hey! I missed this, I'll try to review it today. :)
It looks good to me! Im glad to hear that you are using the lib for such an amazing project. Would you be interested in setting up some tests for the project? I'll open an issue to keep track of it.
It looks good to me! Im glad to hear that you are using the lib for such an amazing project. Would you be interested in setting up some tests for the project? I'll open an issue to keep track of it.
Maybe at some point. Not in the next coming weeks though. Point me to the issue and I'll try to get to it in the near future.
@all-contributors please add @YoussefHenna for doc and code
@teovillanueva
I've put up a pull request to add @YoussefHenna! :tada:
Hey. Great work on this package! It's really amazing and long overdue.
I'm part of the Draftbit team and this will be a great addition to our component selection. The one thing we needed that was missing was the
Callout
component. This PR adds that component + some changes toMarker
to accommodate theCallout
Screenshots
Default/Simple Callout
With
tooltip
enabledWith custom
calloutAnchor
Summary of changes
Callout
componentMarker
to use default anchor (0.5,1)Marker
to supportcalloutAnchor
propMarker
in a class component to supportshowCallout
andhideCallout
Marker
to supportCallout
by passing down a context with callout specific data