teovillanueva / react-native-web-maps

Cross platform maps for react & react-native 🗺
https://teovillanueva.github.io/react-native-web-maps/
MIT License
54 stars 14 forks source link

feat: Update to Expo 48 & react-native-maps 1.3.2 #21

Closed YoussefHenna closed 1 year ago

YoussefHenna commented 1 year ago
YoussefHenna commented 1 year ago

@teovillanueva Hey! This PR updates the versions of everything to be up to date with the latest expo. I've also hit a snag with how you handled the override-types (check my previous comment). Let me know how you'd want to proceed and I can do the appropriate changes.

teovillanueva commented 1 year ago

Hey! Just published a release with the previous changes :) I'll look at this more in detail in the afternoon.

YoussefHenna commented 1 year ago

Good news! The latest version is working on Snack: https://snack.expo.dev/@youssefhenna/teovilla-maps-in-draftbit

teovillanueva commented 1 year ago

Good morning. I've been thinking about the idea of having users import the package directly. That isn't something I particularly like, when I started with the package I thought of it a as a react-native-maps "polyfill" for web, like just using react-native-maps as you would normally do. And regarding the overriden types, if you check the file example/types.ts you can see that you can bring the overriden types into your project just like in nativewiwnd.

teovillanueva commented 1 year ago

Try adding a app.d.ts in your root dir with the following code

/// <reference types="@teovilla/react-native-web-maps/dist/typescript/override-types" />
YoussefHenna commented 1 year ago

Thanks for that suggestion! Fixes the problem with types not being properly overridden. Should be good to go now.

teovillanueva commented 1 year ago

Changes should be published :)