search

teoxoy / factorio-blueprint-editor

A feature-rich Factorio Blueprint Editor
https://fbe.teoxoy.com
MIT License
333 stars 75 forks source link

Fixed effect of beacon for assembling machine #220

Closed Disparity closed 3 years ago

Disparity commented 4 years ago

fixes #218

Disparity commented 4 years ago

I can't check rebased commit because of rebased command yarn start(yarn start:backend) can't run on win =(

teoxoy commented 4 years ago

Oh, I need to update the contributing document to include rust. I think to get up and running, you are missing rust and systemfd.

Let me know if it works and I will then update the docs.

teoxoy commented 4 years ago

How is the performance of the implementation for blueprints with quite a lot of beacons (100+)?

Disparity commented 4 years ago

@Teoxoy sorry for a late reply, I can not run rust (and backend) on windows 10, i get a lot of dependency errors.

How is the performance of the implementation for blueprints with quite a lot of beacons (100+)?

The complexity of algorithm is O(n) so the performance is directly proportional to the number of elements in the blueprint. Each beacon is checked for being in a specific area in which it can have an effect on this building (using a few arithmetic operations).

teoxoy commented 4 years ago

Ok, thanks! Just to let you know, it might take a while until I can merge this PR. I might want to optimize this feature by making it O(1) - since it will be needed for #21 and I'm still working on optimizing the backend for the new release process (everything is blocked by this right now).

ZephD commented 4 years ago

Oh, I need to update the contributing document to include rust. I think to get up and running, you are missing rust and systemfd.

Let me know if it works and I will then update the docs.

and cargo-watch, .env variables.