search

teoxoy / factorio-blueprint-editor

A feature-rich Factorio Blueprint Editor
https://fbe.teoxoy.com
MIT License
299 stars 61 forks source link

[BUG] Land mine positioning is slightly off #236

Closed KenCoder closed 2 years ago

KenCoder commented 2 years ago

Describe the bug Importing then exporting a blueprint with a landmine produces a difference in the blueprint

To Reproduce

  1. Create a blueprint in factory with a land mine and a conveyor belt (as above)
  2. Export the blueprint from Factorio and import into FBE
  3. Ctrl+C to export from FBE, then import into Factorio
  4. Try to place the imported blueprint on top of the existing mine.
  5. You get the error "Land mine is in the way", and you can see that the pasted land mine is a little to the right.

Expected behavior Re-imported blueprint should match original

Screenshots The blueprint: image

Error from step 5 image

Desktop (please complete the following information):

Blueprint String from FBE 0eJyFkN0KwjAMRt8l151oncz10tcQkc4FKXRpaTtxjL677QYy//CuKTknXzJCo3u0TlEAMYK6GPIgjiN4dSWp818YLIIAFbADBiS7XAUnyVvjQtGgDhAZKGrxDmIT2V9YS2qLThEuOB5PDJCCCgrnBFMxnKnvGnRJ/AVnYI1PhKE8K1mK9WrHYJgfMUd5s/BfG3yoXk0p3LSDWNyLwQ2dnwi+35RVzauS1/W2TlG1TNbUfXh2x/gAtWF28A==
teoxoy commented 2 years ago

I think this is caused by the way landmines are imported. They will get aligned to the grid on import.

I thought importing them this way is more useful when editing. It's also easier to support due to the current collision detection data structure being a grid.

Having said that, let me know if you would still consider this a bug.

KenCoder commented 2 years ago

In general, it's nice if blueprints can be pasted back into Factorio without misaligning. Having said that, if the only problem is land mines then I wouldn't spend any time on it as no-one is going to be using them in a blueprint. I found this in my rotation testing and wanted to record it.

teoxoy commented 2 years ago

Let's close this for now then.