search

tepope / pwp_review

A review repository for codecademy programming with python
0 stars 0 forks source link

Summary #2

Open jmcrey opened 6 years ago

jmcrey commented 6 years ago

Rubric Score

Criteria 1: Matplotlib and CSV

The Jupyter notebook file imports the libraries necessary for the project. Nice job using the get_ipython() function to import the matplotlib library by the way -- creative way to import this necessary package! You can also use the command %matplotlib notebook to import it, but the way it is currently being done is perfectly acceptable. Just a matter of preference!

Criteria 2: Implementation of 2D Visualization

The 2D grid appears with data plotted on the graph perfectly. Unfortunately, it does not include a custom title, marker or color (more on that here), but the code that displays the graph is perfect.

Criteria 3: Implementation of 3D Visualization

The 3D grid appears with the correct data plotted on the graph. Again, there is no customization and no title on this grid either; but, it does rotate and it is displays the data perfectly.

Overall Score: 10/12

Overall this project displayed both graphs perfectly. Although they lacked customizations such as colors, titles, or varying markers, they perfectly displayed the data and the code ran perfectly. Moving forward, we should try to make the graphs more clear by using optional parameters such as color and marker in our scatter function, and adding a title to the graphs using the title function. An example of customizing the colors and markers for the 2D graph is as follows:

plt.scatter(x,y, color= 'green', marker='*')

This will display the graph with green stars as the markers, which will make it even more clear that we're displaying a constellation. The title was discussed in an earlier issue. But, again, this project was very successful at displaying the graphs properly. So, great job overall!

tepope commented 6 years ago

Thanks for the review! I was a little unclear on what was required, since the instructions in the ipython notebook made it so that this project was not very challenging..

jmcrey commented 6 years ago

@tepope Thank you for your comment! If you did not find this course challenging enough and would like a deeper dive into Python (with a little bit more freedom in the style of coding) I would highly recommend the Codecademy Intensive Programming with Python (PWP). It is a much more involved Python intensive that ends with a full-fledged project, where you implement multiple classes and functions. Just something to think about!

tepope commented 6 years ago

Thanks Jeremiah. If youre referring to this course --> https://www.codecademy.com/pro/intensive/programming-with-python <--, I have already completed it. Im interested in the data visualization component of this course, but I would love any additional recommendations you have to expand my python experience.

On Thu, Aug 23, 2018 at 5:16 PM Jeremiah McReynolds < notifications@github.com> wrote:

@tepope https://github.com/tepope Thank you for your comment! If you did not find this course challenging enough and would like a deeper dive into Python (with a little bit more freedom in the style of coding) I would highly recommend the Codecademy Intensive Programming with Python (PWP). It is a much more involved Python intensive that ends with a full-fledged project, where you implement multiple classes and functions. Just something to think about!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tepope/pwp_review/issues/2#issuecomment-415612053, or mute the thread https://github.com/notifications/unsubscribe-auth/AGDSm-utd__15iq_MutA6wdfXc2SfPQpks5uT0XagaJpZM4WCrLd .