teqnology / alfresco-login-reset-share

Alfresco Share new materialize login page and an Activiti reset password workflow feature
GNU General Public License v3.0
2 stars 9 forks source link

Added i18n #3

Closed n11c closed 8 years ago

n11c commented 8 years ago

Added i18n support and french translations. Also improved ajax errors handling to avoid the use of eval().

Some of the changes have been made to suit the changes proposed on the repo AMP (see https://github.com/teqnology/alfresco-login-reset-repo/pull/2)

teqnology commented 8 years ago

Hey sorry for not getting back to you sooner. I was really busy. I'll make some time this weekend to review the whole, and let you know how it goes. On a side note, there is an open bug where Share pages done through the ftl templating like this project (except for the login page declared in the context file), are not supported when external auth is configured (there is none) doesn't seem to be picked up. Any ideas on how to workaround that one? maybe put everything on a single login page, in terms of hidden divs?

teqnology commented 8 years ago

Tested locally, and on a remote Alfresco 5.1 instance. Really nice work, much appreciated. Merge completed, leaving this issue open for a few days, just to be sure everything's fine. Will close soon if no issues are found