search

teracow / googliser

a fast BASH multiple-image downloader
GNU General Public License v3.0
207 stars 38 forks source link

RFC: considering removing some user options #62

Closed teracow closed 4 years ago

teracow commented 4 years ago

Hey all. :)

~Because it works so well, I've made --race a default action for now, and I'm looking at removing it as a user-option. This means image download numbers will nearly always over-run and need to be trimmed back, but it's turned-out to be a really fast way of getting images.~

~Also I'd like to remove --always-download and make it the default action.~

And remove any need for the user to specify failure-limits via --failures. Unlimited download failures should always be allowed (I can't think of a reason to limit this).

Removing these options will cause a runtime error "invalid arguments" for anyone still using them.

Thoughts please?

teracow commented 4 years ago

https://github.com/teracow/googliser/commit/a84d476053eb6d797bbed77c4544b0f7f748865b

teracow commented 4 years ago

https://github.com/teracow/googliser/commit/95b283c469b712a5200d616b6365a9e75ef372c8

MBtech commented 4 years ago

I agree with the changes already made and I think removal of failure limit also makes sense. I would actually also suggest to make --no-gallery default too and instead give the option to create the gallery explicitly because that seems like a use case specific thing.

teracow commented 4 years ago

@MBtech agree, I've been considering that too.

OK, I'll begin working on making galleries optional. :)

teracow commented 4 years ago

... and done! https://github.com/teracow/googliser/commit/5cabdc19f05c104764b4441fbaa9e7af0a4123eb

MBtech commented 4 years ago

Great!