search

teracyhq / docker-files

Teracy docker-files project to build common Docker images
https://hub.docker.com/r/teracy/
MIT License
92 stars 55 forks source link

Release a new tag #76

Closed xchopin closed 2 years ago

xchopin commented 2 years ago

Hi,

is it possible to release a new tag for angular-cli on DockerHub? the last tag is one year old and using "latest" in pipelines isn't a good practice 😅

Thank you!

hoatle commented 2 years ago

hello @xchopin, you can check https://hub.docker.com/r/teracy/angular-cli/tags that the "latest" tag was published ~15 hours ago, it's scheduled to be updated every day by the github action.

xchopin commented 2 years ago

thanks for replying @hoatle indeed for now I must use "latest" instead of a specific version (such as 10.2) which would be better for a production use case.

Also, great news! thank you

hoatle commented 2 years ago

we're so busy for specific versions maintenance, you can try to create a PR to build a specific version for angular-cli by adding it to this file: https://github.com/teracyhq/docker-files/blob/master/.github/workflows/build-push.yaml#L25

You need to add this NG_CLI_VERSION argument: https://github.com/teracyhq/docker-files/blob/master/angular-cli/base/Dockerfile#L12

PR is welcomed @xchopin.

xchopin commented 2 years ago

Thanks for the info I did this one, not sure if it's all good :) https://github.com/teracyhq/docker-files/pull/77/files