search

teradaian / hanafuda

4 stars 0 forks source link

Field flashes when animated #2

Open pkoronawa opened 3 years ago

pkoronawa commented 3 years ago

Adding a new card or floating a pair out causes whole field to flash.

teradaian commented 3 years ago

This afaik is caused by the rendering method, I imagine conditionally rendering only changing cards would be the next logical step as far as performance, which I'll try to dive into if I have time!

pkoronawa commented 3 years ago

I was running in Edge with IISExpress for debugging. Didn’t see the same issues on your deployed app on meticulous

Sent from my iPhone

On Jun 29, 2021, at 7:58 AM, Ian Terada @.***> wrote:

 This afaik is caused by the rendering method, I imagine conditionally rendering only changing cards would be the next logical step as far as performance, which I'll try to dive into if I have time!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

teradaian commented 3 years ago

I'll run it on Edge and FF and check!