search

teragrep / ajs_01

User interface for Teragrep
Apache License 2.0
0 stars 1 forks source link

serverside table needs clear button twice to disappear #106

Closed kortemik closed 1 year ago

kortemik commented 1 year ago

ID <163> Reporter <@kortemik>

serverside table needs clear button twice to disappear, at least when used from paragraph controls

kortemik commented 1 year ago

User <@kortemik> Date <[2022-04-20T10:09:50Z]>

dtnet.png

before clear

kortemik commented 1 year ago

User <@kortemik> Date <[2022-04-20T10:10:01Z]>

dtnet2.png after clear

kortemik commented 1 year ago

User <@kortemik> Date <[2022-04-20T10:10:08Z]>

after second clear it disappears

kortemik commented 1 year ago

User <@kortemik> Date <[2022-04-26T10:25:46Z]>

fixed in 3.0.4

kortemik commented 1 year ago

User <@ronja-ui> Date <[2022-05-06T09:21:18Z]>

reopening this issue since it needs a test-case to be done.

BVVLD commented 1 year ago

the clear feature in the zeppelin is working as such: when the clear button is pressed, a server call is sent with paragraph ID, the server then sends an update of the paragraph (a copy of it) with child object "results" removed. The "update_paragraph" event is broadcasted and an update for the paragraph is performed on the UI side. In the end, since the "results" subobject is set to "undefined" (according to the legacy code), the result element block in paragraph.html is removed and not rendered. the current tests simulate server call trigger, checking the correct paragraph ID send to the server, simulate the broadcast, checking that correct functions are invoked and simulate the update process, checking that the final paragraph contains empty 'results' subobject.