teragrep / ajs_01

User interface for Teragrep
Apache License 2.0
0 stars 0 forks source link

Investigate is a regular line break possible in tables #162

Open kortemik opened 1 year ago

kortemik commented 1 year ago

ID <251> Reporter <@ronja-ui>

Investigate if it's possible to have regular line breaks in tables (in DPL language as well).

If it's not possible, figure out a solution that allows line breaks in dpl tables

kortemik commented 1 year ago

User <@ronja-ui> Date <[2022-09-22T08:08:47Z]>

there are two ways to make the line break in HTML+CSS:

example 1:

<tbody>
  <tr class="odd">
    <td class="sorting_1 sorting_2">timestamp</td>
    <td>Line 1<br />Line 2</td>
  </tr>
</tbody>


example 2:

<tbody>
  <tr class="odd">
    <td class="sorting_1 sorting_2">timestamp</td>
    <td>
      <span class="d-block">Line 1</span>
      <span class="d-block">Line 2</span>
    </td>
  </tr>
</tbody>
kortemik commented 1 year ago

User <@BVVLD> Date <[2022-09-22T10:18:03Z]>

The current solution allows DT to display the line breaks as it is shown in Example 2. The line should contain "\n" or "\r". Another way to display it, is to supply the DT an array of strings, which will be formatted the same way.

Right now, the solution should be tested and (hopefully) closed.

kortemik commented 1 year ago

User <@ronja-ui> Date <[2022-11-24T14:14:32Z]>

The answer may lie in css after all:

kortemik commented 1 year ago

User <@ronja-ui> Date <[2022-11-25T06:15:49Z]>

nevermind, it looks like the issue was already solved but unclosed.

currently, if you use \n in dpl string values, it will create the line break. will do more tests with this before closing the issue.

kortemik commented 1 year ago

User <@ronja-ui> Date <[2022-11-25T06:46:28Z]>

tested on tg6 that both \n and \r works with string values. only unit tests are undone.