teragrep / ajs_01

User interface for Teragrep
Apache License 2.0
0 stars 0 forks source link

Padding? increases after each batch between paragraph input and table #177

Closed kortemik closed 2 months ago

kortemik commented 1 year ago

ID <282> Reporter <@eemhu>

Seems like the padding? ( or maybe it's trying to draw the other type of table when aggregates are not used with empty data, just a guess) is increasing after each processed batch.

You can resize it and it disappears if you do that.

padding.webm

kortemik commented 1 year ago

User <@ronja-ui> Date <[2022-11-29T12:33:56Z]>

There's an empty div that sometimes creates a situation like in the video. In practice, the empty div prints line breaks which CSS handles as pre tag content.

<div ng-mouseout="onMouseOut()" ng-mouseover="onMouseOver()" id="pparagraph_1669709773809_1384397223_0_resize" ng-if="!config.helium.activeApp" resize="{&quot;allowresize&quot;: &quot;true&quot;, &quot;graphType&quot;: &quot;TEXT&quot;}" resizable="" on-resize="resize(width, height);" class="ng-scope ng-isolate-scope ui-resizable ui-resizable-autohide">
  <!-- ngIf: type=='TABLE' || type == 'NETWORK' -->
  <!-- ngIf: type == 'TEXT' --><div ng-if="type == 'TEXT'" class="plainTextContainer ng-scope" ng-style="getPointerEvent()" style="pointer-events: none;">
    <div id="pparagraph_1669709773809_1384397223_0_text" style="max-height: 300px;" class="text plainTextContent overflow-auto">

</div>
  </div><!-- end ngIf: type == 'TEXT' -->
  <!-- ngIf: !isDefaultDisplay() -->
  <!-- ngIf: type == 'ELEMENT' -->
  <!-- ngIf: type == 'HTML' -->
  <!-- ngIf: type == 'ANGULAR' -->
  <!-- ngIf: type == 'IMG' -->
<div class="ui-resizable-handle ui-resizable-se ui-icon ui-icon-gripsmall-diagonal-se" style="z-index: 90; display: none;"></div></div>
ronja-ui commented 11 months ago

since the height resizing feature was removed, this doesn't occur in this scale anymore.

however, there is still the empty paragraph div for text content. at maximum its height is ~16px which isn't that much but it makes the whole paragraph-output to fidget.

the correct solution to this problem is to ensure there's no empty div containers in paragraph-output.

BVVLD commented 7 months ago

the server sometimes starts to send this message on every batch update: { "op": "PARAGRAPH_APPEND_OUTPUT", "data": { "data": "\n", "index": 0, "noteId": "2JEF7JF7C", "paragraphId": "paragraph_1699456285230_571125281" }, "ticket": "anonymous", "principal": "anonymous", "roles": "" }

Which adds a /n to the text output on every batch, resulting it growing in size

BVVLD commented 7 months ago

The problem is currently partially solved from UI side by watching for such updates and ignoring them. This is not a right way to solve it in long term, but a temporal measure to prevent UI breaking and slowing down, due to the piling up paragraph updates.