teragrep / ajs_01

User interface for Teragrep
Apache License 2.0
0 stars 0 forks source link

Navbar note navigation and home page note navigation are two completely separate solutions #198

Open BVVLD opened 1 year ago

BVVLD commented 1 year ago

The search/open notes in the home page is implemented via 3 HTML files: home.html, notebook.html and notebook-template.html and operated via one controller: home.controller.js. The navbar element, which represents identical function in the UI is implemented with 2 HTML files: navbar.html and navbar-note-list-elem.html, supported with a custom angularJS directive expand-collapse.directive.js and controlled with navbar.controller.js. While both elements work as they are expected, this solution was found not very optimal, since it requires to change two different elements in order to consistently change one feature. Also, the navbar implementation uses its own jQuery and CSS logic, which is redundant and replaced with Bootstrap built-ins in the home implementation.

Task: investigate the possibility of refactoring these implementations into one, which is used in both places.