teragrep / cfe_31

0 stars 0 forks source link

Getters can be substituted for public final fields #14

Closed MoonBow-1 closed 2 months ago

MoonBow-1 commented 8 months ago

If a field is final, it can be made into a public field, removing the getter for it.

private ArchiveDir archivingDir;

public ArchiveDir getArchivingDir() {
  return archivingDir;
}

Can just be made into:

public ArchiveDir archivingDir;
MoonBow-1 commented 7 months ago

These have been removed were possible, there might be more after merging all branches to main

MoonBow-1 commented 7 months ago

CaptureDefinitionEntry has been fixed by removing the fromjson() method which allows for final fields now

MoonBow-1 commented 6 months ago

RelpCaptureDefinition's getters have been removed

MoonBow-1 commented 6 months ago

CaptureDefinitionWithSink is dependent on its own getCaptureDefinition() method to cast the captureDef to CFE-01 type. This might be a new ticket to refactor the inheritance