teragrep / cfe_31

0 stars 0 forks source link

Null values should be removed #16

Closed MoonBow-1 closed 7 months ago

MoonBow-1 commented 8 months ago

Closely tied to #15

Methods should throw Exceptions instead of returning null values.

MoonBow-1 commented 8 months ago

Removing null values and switching to exceptions caused some captures to not be sent, investigating the reasons currently. At least one of the reasons was a RELP capture missing the "relp" from the directory name.

MoonBow-1 commented 8 months ago

Actually seems that it's more about HostGroups. About 50 of them are not sent compared to commit ddd035c2

MoonBow-1 commented 8 months ago

Pinpointed this issue to commit 6365df6b, will check the changes and fix this.

MoonBow-1 commented 8 months ago

Fixed most of the missing things in commit 19cedc49, but 1 capture and 1 host are still not sent, going to investigate this

MoonBow-1 commented 8 months ago

Going to put this small problem on the back-burner for now, going to fix the rest of the null returns first

MoonBow-1 commented 8 months ago

HTTP client has been refactored to throw Exceptions instead of returning null

MoonBow-1 commented 8 months ago

All null return statements have been removed in commit a3fd3a25