Open MoonBow-1 opened 6 months ago
Inconsistent capitalization found in:
HostIPPayload
HostInterfacePayload
Before:
public HostInterfacePayload(final String interfaceType, final int hostMetaID) {
this.interfaceType = interfaceType;
hostMetaId = hostMetaID;
}
public HostIPPayload(final String ipAddress, final int hostMetaID) {
this.ipAddress = ipAddress;
hostMetaId = hostMetaID;
}
After:
public HostInterfacePayload(final String interfaceType, final int hostMetaId) {
this.interfaceType = interfaceType;
this.hostMetaId = hostMetaId;
}
public HostIPPayload(final String ipAddress, final int hostMetaId) {
this.ipAddress = ipAddress;
this.hostMetaId = hostMetaId;
}
StringCaseLocaleUsage fix:
Before:
.toLowerCase()
After:
.toLowerCase(Locale.forLanguageTag("fi"))
Uses IETF language tags
NonApiType warnings fixed:
Before:
ArrayList<x> list = new ArrayList<>();
After:
List<x> list = new ArrayList<>();
DefaultCharset warnings fixed:
Before:
string.getBytes();
After:
string.getBytes(StandardCharsets.UTF_8);
ZonedDateTime warning fixed:
Before:
return ZonedDateTime
.now()
.format(DateTimeFormatter.ISO_INSTANT);
After:
return ZonedDateTime
.now(ZoneId.systemDefault())
.format(DateTimeFormatter.ISO_INSTANT);
Description
There are 39 warnings about error-prone code, mostly NonApiType ArrayLists and missing locale declarations.
CFE01GenerateFile
(extendsRelpGenerateFile
)HubDirList