teragrep / cfe_31

0 stars 0 forks source link

Remove Optional<> wrappers #37

Closed MoonBow-1 closed 5 months ago

MoonBow-1 commented 6 months ago

Description

Title Use case or motivation behind the feature request

Optional wrappers are basically just null values, so its better to move away from them and use exceptions

Additional context

yegor

MoonBow-1 commented 6 months ago

Archive.getArchiveDirByName before:

public Optional<ArchiveDir> getArchiveDirByName(final String name) {
    return directories.stream().filter(archiveDir -> archiveDir.dir.getName().equals(name)).findFirst();
}

After:

public ArchiveDir getArchiveDirByName(final String name) throws NoSuchElementException {
    return directories.stream().filter(archiveDir -> archiveDir.dir.getName().equals(name)).findFirst().orElseThrow();
}