teragrep / pth_06

Teragrep Datasource for Apache Spark
GNU Affero General Public License v3.0
0 stars 5 forks source link

Incorrect expression (COPY_PASTE_ERROR) in RowConverter.java: 345 #55

Open StrongestNumber9 opened 2 months ago

StrongestNumber9 commented 2 months ago

Describe the bug

 *** CID 1594357:  Incorrect expression  (COPY_PASTE_ERROR)
/src/main/java/com/teragrep/pth_06/task/s3/RowConverter.java: 345 in com.teragrep.pth_06.task.s3.RowConverter.eventToSource()()
339             else {
340                 source_hostname = new byte[]{};
341             }
342     
343     
344             Fragment sourceSourceFragment = rfc5424Frame.structuredData.getValue(eventNodeSourceSource);
>>>     CID 1594357:  Incorrect expression  (COPY_PASTE_ERROR)
>>>     "sourceHostnameFragment" in "sourceHostnameFragment.isStub" looks like a copy-paste error.
345             if (sourceHostnameFragment.isStub) {
346                 sourceSourceFragment = rfc5424Frame.structuredData.getValue(eventNodeRelaySource);
347             }
348     
349             byte[] source_source;
350             if (!sourceSourceFragment.isStub) {

Software version

3.0.1

StrongestNumber9 commented 2 months ago

See also #54 as it is very copypastey codeblock