teragrep / pth_06

Teragrep Datasource for Apache Spark
GNU Affero General Public License v3.0
0 stars 5 forks source link

Resource leaks in StreamDBClient.java: 186 #57

Open StrongestNumber9 opened 2 months ago

StrongestNumber9 commented 2 months ago

Describe the bug

 *** CID 1594355:  Resource leaks  (RESOURCE_LEAK)
/src/main/java/com/teragrep/pth_06/planner/StreamDBClient.java: 186 in com.teragrep.pth_06.planner.StreamDBClient.pullToSliceTable(java.sql.Date)()
180                             .join(JOURNALDB.LOGFILE).on(JOURNALDB.LOGFILE.ID.eq(nestedTopNQuery.id))
181                             .join(JOURNALDB.BUCKET).on(JOURNALDB.BUCKET.ID.eq(JOURNALDB.LOGFILE.BUCKET_ID))
182                             .join(JOURNALDB.HOST).on(JOURNALDB.HOST.ID.eq(JOURNALDB.LOGFILE.HOST_ID));
183     
184             LOGGER.trace("StreamDBClient.pullToSliceTable select <{}>", select);
185             final Instant stopwatch = Instant.now();
>>>     CID 1594355:  Resource leaks  (RESOURCE_LEAK)
>>>     Failing to save or close resource created by "ctx.insertInto(com.teragrep.pth_06.planner.StreamDBClient.SliceTable.SLICE_TABLE).select(select)" leaks it.
186             int rows = ctx.insertInto(SliceTable.SLICE_TABLE).select(select).execute();
187     
188             LOGGER.info("StreamDBClient.pullToSliceTable" + ": took (" + (Instant.now().toEpochMilli() - stopwatch.toEpochMilli()) + "ms)");
189             return rows;
190     
191         }

Software version

3.0.1