search

teragrep / zep_01

0 stars 0 forks source link

Renaming notebooks in Zeppelin #20

Open Laukkala opened 9 months ago

Laukkala commented 9 months ago

Current Zeppelin implementation of renaming notebooks is odd, it's moving notebooks around. Currently, on receiving a NOTE_RENAME message, the following procedure is followed: NotebookServer.renameNote() -> NotebookService.renameNote() -> Notebook.moveNote() -> NoteManager.moveNote() -> NotebookRepo.move() -> NotebookRepo.save()

Renaming should only change the title of the desired Notebook, and then save the changes. Refactoring is required for the whole renaming process.

Laukkala commented 9 months ago

Looks like original idea behind using moveNote() here was that you could create folders automatically by using backslashes while renaming a notebook. Eg. Notebook1 -> NewFolder/Notebook1. Not sure if that feature has ever seen any use. If nothing else it makes the renaming process really confusing